You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flattern files will faile because the duplicated BitMaps import, thus we strongly suggest that you could replace the imported BitMaps library in the /contracts/token/erc721/abstract/ERC721Hybrid.sol with _import {BitMaps} from "solidity-bits/contracts/BitMaps.sol"; in the \contracts\token\erc721\erc721psi\ERC721PsiBurnable.sol.
@yuhuajing we are discussing the merits of your PR. One decision we have made is that we won't include IDE specific files in the repo. As such, could you update your PR to gitignore the whole .idea directory, and remove the associated files from your PR
A result of the change beyond flatten files possibly being easier, is that the resulting contract should be smaller. ERC721Psi calls set and get on solidity-bits version of BitMaps, where as ImmutableERC721Base uses the same functions in Open Zeppelin's code. This means that two copies of these functions will be included in the final contract bytecode. Making the change described in this PR will mean there is only one copy of the set and get functions.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yuhuajing
force-pushed
the
replaceBitMaps
branch
2 times, most recently
from
The flattern files will faile because the duplicated BitMaps import, thus we strongly suggest that you could replace the imported BitMaps library in the /contracts/token/erc721/abstract/ERC721Hybrid.sol with
_import {BitMaps} from "solidity-bits/contracts/BitMaps.sol";in the \contracts\token\erc721\erc721psi\ERC721PsiBurnable.sol.